From b25c5dafb4a84af6bb20b8f5f771f8314a4e925e Mon Sep 17 00:00:00 2001 From: David Evans Date: Thu, 10 May 2018 22:18:25 +0100 Subject: [PATCH] Run tests in FireFox now that version 60 has been released [#51] --- docs/CONTRIBUTING.md | 9 ++------- spec/support/karma.conf.js | 6 +----- 2 files changed, 3 insertions(+), 12 deletions(-) diff --git a/docs/CONTRIBUTING.md b/docs/CONTRIBUTING.md index 81f7794..d16383d 100644 --- a/docs/CONTRIBUTING.md +++ b/docs/CONTRIBUTING.md @@ -27,12 +27,6 @@ several pages: * [http://localhost:8080/library.htm](http://localhost:8080/library.htm): the library sample page -**NOTE**: When running in `dev` mode, this project uses web modules, -which are only supported by recent browsers. In particular, note that -FireFox 59 does not support web modules unless a flag is set (FireFox -60 will support them fully). Production mode does not require web -modules, so should have wider support. - To run the tests and linter, run the command: ```shell @@ -60,7 +54,8 @@ server if you make changes) The available commands are: * `npm start`: runs a webserver on - [localhost:8080](http://localhost:8080) + [localhost:8080](http://localhost:8080) (using minified sources) +* `npm start -- dev`: runs a webserver using non-minified sources * `npm test`: runs the `unit-test`, `web-test` and `lint` commands * `npm run unit-test`: runs non-browser-based unit tests in NodeJS * `npm run web-test`: runs browser-based unit tests via Karma diff --git a/spec/support/karma.conf.js b/spec/support/karma.conf.js index 87ba757..a87f12e 100644 --- a/spec/support/karma.conf.js +++ b/spec/support/karma.conf.js @@ -1,12 +1,8 @@ const manual = Boolean(process.env.MANUAL); -/* - * Firefox is supported, but tests will fail until version 60 is out - * due to the use of es6 modules, so exclude it for now. - */ const SUPPORTED_BROWSERS = [ 'chrome', - // 'firefox', + 'firefox', 'safari', ];