yaroslav
/
SequenceDiagram
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Run tests in FireFox now that version 60 has been released [#51]

This commit is contained in:
David Evans 2018-05-10 22:18:25 +01:00
parent 827bcbbe0b
commit b25c5dafb4
2 changed files with 3 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
docs/CONTRIBUTING.md
View File

@ -27,12 +27,6 @@ several pages:
* [http://localhost:8080/library.htm](http://localhost:8080/library.htm): * [http://localhost:8080/library.htm](http://localhost:8080/library.htm):
the library sample page the library sample page
**NOTE**: When running in `dev` mode, this project uses web modules,
which are only supported by recent browsers. In particular, note that
FireFox 59 does not support web modules unless a flag is set (FireFox
60 will support them fully). Production mode does not require web
modules, so should have wider support.
To run the tests and linter, run the command: To run the tests and linter, run the command:
```shell ```shell
@ -60,7 +54,8 @@ server if you make changes)
The available commands are: The available commands are:
* `npm start`: runs a webserver on * `npm start`: runs a webserver on
[localhost:8080](http://localhost:8080) [localhost:8080](http://localhost:8080) (using minified sources)
* `npm start -- dev`: runs a webserver using non-minified sources
* `npm test`: runs the `unit-test`, `web-test` and `lint` commands * `npm test`: runs the `unit-test`, `web-test` and `lint` commands
* `npm run unit-test`: runs non-browser-based unit tests in NodeJS * `npm run unit-test`: runs non-browser-based unit tests in NodeJS
* `npm run web-test`: runs browser-based unit tests via Karma * `npm run web-test`: runs browser-based unit tests via Karma

6
spec/support/karma.conf.js
View File

@ -1,12 +1,8 @@
const manual = Boolean(process.env.MANUAL); const manual = Boolean(process.env.MANUAL);
/*
* Firefox is supported, but tests will fail until version 60 is out
* due to the use of es6 modules, so exclude it for now.
*/
const SUPPORTED_BROWSERS = [ const SUPPORTED_BROWSERS = [
'chrome', 'chrome',
// 'firefox', 'firefox',
'safari', 'safari',
]; ];